Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ros2service] call only once by default #67

Merged
merged 2 commits into from
Dec 6, 2017

Conversation

mikaelarguedas
Copy link
Member

No description provided.

@mikaelarguedas mikaelarguedas added the in progress Actively being worked on (Kanban column) label Dec 6, 2017
@dirk-thomas
Copy link
Member

Calling a service repeatedly as fast as possible sounds like a reasonable use case to me. Therefore I wouldn't use that to represent "once".

Instead I would suggest to remove the default value of the --rate argument (which makes it None). And pass 1. / args.rate if args.rate else None to the requester function (removing the once argument).

@mikaelarguedas mikaelarguedas added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Dec 6, 2017
@mikaelarguedas
Copy link
Member Author

Fair enough, updated accordingly

@mikaelarguedas mikaelarguedas merged commit e8abe8a into master Dec 6, 2017
@mikaelarguedas mikaelarguedas deleted the ros2service_once_default branch December 6, 2017 21:36
@mikaelarguedas mikaelarguedas removed the in review Waiting for review (Kanban column) label Dec 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants