Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add QoS history and depth information if available. #678

Merged
merged 1 commit into from
Dec 22, 2021

Conversation

fujitatomoya
Copy link
Collaborator

depends ros2/rclpy#849

Signed-off-by: Tomoya Fujita Tomoya.Fujita@sony.com

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya
Copy link
Collaborator Author

fujitatomoya commented Dec 8, 2021

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status (rerun by @audrow)

Copy link
Member

@audrow audrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me with green CI.

@audrow
Copy link
Member

audrow commented Dec 21, 2021

The Windows CI error seems to be a known flaky test, ros2/launch_ros#280.

@fujitatomoya fujitatomoya merged commit 05f2ae7 into ros2:master Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants