ignore empty or None node names #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjwwood
approved these changes
Feb 8, 2018
This was referenced Feb 22, 2018
dirk-thomas
force-pushed
the
node_name_in_user_data
branch
from
395dcdd
to
4782c79
Compare
dirk-thomas
force-pushed
the
node_name_in_user_data
branch
from
4782c79
to
238cbf9
Compare
dirk-thomas
force-pushed
the
node_name_in_user_data
branch
from
238cbf9
to
a3acd65
Compare
5 tasks
esteve
pushed a commit
to esteve/ros2cli
that referenced
this pull request
Dec 16, 2022
* first commit for ros2launch * Label linters * fix for changed function name * thread-safety * use alternative shutdown of ROS stuff, that I was planning to use before * fixup alpha linter label * add dependency on launch * Comment fixup/additions * fix flake8 warning (even if it is false positive)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connect to ros2/ros2#438.