Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix import order #79

Merged
merged 1 commit into from
Feb 12, 2018
Merged

fix import order #79

merged 1 commit into from
Feb 12, 2018

Conversation

mikaelarguedas
Copy link
Member

new version of flake8 complains as xmlrpc is considered a system header and thus needs to be imported in the previous block.

cc @wjwwood as build cop

@mikaelarguedas mikaelarguedas added the in progress Actively being worked on (Kanban column) label Feb 12, 2018
@mikaelarguedas
Copy link
Member Author

Before the patch:

With this patch:

  • Linux Build Status

@mikaelarguedas mikaelarguedas added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Feb 12, 2018
@mikaelarguedas mikaelarguedas merged commit 8340537 into master Feb 12, 2018
@mikaelarguedas mikaelarguedas deleted the fix_flake8 branch February 12, 2018 17:47
@mikaelarguedas mikaelarguedas removed the in review Waiting for review (Kanban column) label Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirk-thomas dirk-thomas dirk-thomas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mikaelarguedas @dirk-thomas