print full help when no command is passed #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ros2cli/ros2cli/command/daemon.py
Outdated
| # in case no verb was passed | ||
| self._subparser.print_help() | ||
| return 0 | ||
|
|
||
| # the attribute should always exist | ||
| # otherwise argparse should have exited |
There was a problem hiding this comment.
I don't think this comment is necessary anymore as the attribute existence is checked just above (same everywhere below)
There was a problem hiding this comment.
Removed the obsolete comments.
dirk-thomas
force-pushed
the
help_without_command
branch
from
78b4661
to
72c4bbd
Compare
esteve
pushed a commit
to esteve/ros2cli
that referenced
this pull request
Dec 16, 2022
* Use commented typing for variables * Fix mypy error that __init__ must return None * Remove trailing commas in __init__ signatures * Additional casting where needed * Correct return type of pid getter * Remove more commas in launch_ros * Add comment for different variable name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When no
command/verbis passed the full help is printed as if the user would have passed--help.Fixes #74.
The API is backward compatible so that the behavior of existing extensions isn't changes. Extensions implemented in other repositories could be updated in the same way (not to require the
verb) if they want to show the full help text in that case.