Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update ros2 param list output for a specific node #98

Merged
merged 1 commit into from
Jun 12, 2018
Merged

update ros2 param list output for a specific node #98

merged 1 commit into from
Jun 12, 2018

Conversation

dirk-thomas
Copy link
Member

@dirk-thomas dirk-thomas commented Jun 12, 2018 •
edited
Loading

Not showing the node name when a specific node was requested.

Follow up of #95.

@dirk-thomas dirk-thomas added enhancement New feature or request in review Waiting for review (Kanban column) labels Jun 12, 2018
@dirk-thomas dirk-thomas self-assigned this Jun 12, 2018
mikaelarguedas
mikaelarguedas approved these changes Jun 12, 2018
View reviewed changes
Copy link
Member

@mikaelarguedas mikaelarguedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm,

Side question: should we keep printing node names for nodes that don't have any parameter?

WIth this patch and a single node running that doesn't have any parameter:

$ ros2 param list 
parameter_node:
$ ros2 param list parameter_node

@dirk-thomas
Copy link
Member Author

dirk-thomas commented Jun 12, 2018 •
edited
Loading

The information which node has been queried sounds useful (at least some times). An option to toggle between both behaviors would certainly be good.

@dirk-thomas dirk-thomas merged commit 20c2a88 into master Jun 12, 2018
@dirk-thomas dirk-thomas deleted the ros2param_list_output branch June 12, 2018 16:10
@wjwwood wjwwood removed the in review Waiting for review (Kanban column) label Jun 12, 2018
esteve pushed a commit to esteve/ros2cli that referenced this pull request Dec 16, 2022
@BMarchi
Merge pull request ros2#98 from ros2/BMarchi/add_pid_suffix_to_launch…
848b201 
…_ros

Add pid to launch_ros node name as suffix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikaelarguedas mikaelarguedas mikaelarguedas approved these changes

Assignees

@dirk-thomas dirk-thomas

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dirk-thomas @mikaelarguedas @wjwwood