Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing arg to ros2 service list #99

Merged
merged 1 commit into from
Jun 12, 2018

Conversation

dirk-thomas
Copy link
Member

@dirk-thomas dirk-thomas commented Jun 12, 2018

While args.include_hidden_services was already passed to get_service_names_and_types there was no such argument.

Introduced in 19c4b53#diff-99282886dcb729c86c53a547c34b02c2R36

@dirk-thomas dirk-thomas added bug Something isn't working in review Waiting for review (Kanban column) labels Jun 12, 2018
@dirk-thomas dirk-thomas self-assigned this Jun 12, 2018
Copy link
Member

@mikaelarguedas mikaelarguedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, though I didn't test it

@dirk-thomas dirk-thomas merged commit a0d57f4 into master Jun 12, 2018
@dirk-thomas dirk-thomas deleted the ros2service_list_missing_arg branch June 12, 2018 16:11
@wjwwood wjwwood removed the in review Waiting for review (Kanban column) label Jun 12, 2018
esteve pushed a commit to esteve/ros2cli that referenced this pull request Dec 16, 2022
esteve pushed a commit to esteve/ros2cli that referenced this pull request Dec 16, 2022
Signed-off-by: Brian Ezequiel Marchi <brian.marchi65@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants