Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ros_testing metapackage and ros2test CLI package #1

Merged
merged 8 commits into from
May 17, 2019

Conversation

hidmic
Copy link
Contributor

@hidmic hidmic commented May 15, 2019

Closes ros2/launch#208. This pull request adds:

  • ros_testing, the ament_cmake entrypoint package to launch testing in ROS2, bringing all necessary dependencies and providing a convenience CMake macro, add_ros_test() to register ROS2 launch tests.
  • ros2test, the ros2 CLI extension package that provides a test command for ROS2 launch tests.

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic
Copy link
Contributor Author

hidmic commented May 15, 2019

Running CI (running up to several system_tests and demo package to save time, using ros2/ros2#704 for a ros2.repos file):

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

Previous runs with known/unrelated failures:

  • Packaging Linux Build Status
  • macOS Build Status

@wjwwood
Copy link
Member

wjwwood commented May 15, 2019

What did we decide I should rename this repository to? ros2test, ros_testing?

Copy link
Member

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

schematypens="http://www.w3.org/2001/XMLSchema"?>
<package format="2">
<name>ros2test</name>
<version>0.8.1</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any particular reason for starting at this version? I don't think it matters where you start, but I was just curious.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just matching the version of most of the other launch packages. Any other way you'd rather go about it? I don't have a strong preference and I can't tell if we have a stricter policy on this regard.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since both are in separate repositories they will level independently. So there is no reason to align them now. Please start this repo with version 0.1.0.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough.

@hidmic
Copy link
Contributor Author

hidmic commented May 16, 2019

What did we decide I should rename this repository to? ros2test, ros_testing?

I think we didn't really decide. I'm fine with either, though I used ros_testing purposefully to avoid confusion with ROS1 rostest and to have ros2test available for the CLI extension package.

@dirk-thomas
Copy link
Member

I used ros_testing purposefully to avoid confusion with ROS1 rostest

How about naming this repo ros_testing then?

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic
Copy link
Contributor Author

hidmic commented May 16, 2019

Tests seem unrelated though no less worrisome :/

@hidmic hidmic merged commit c69c48e into master May 17, 2019
@delete-merged-branch delete-merged-branch bot deleted the hidmic/add-ros2-testing branch May 17, 2019 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

merging with ApexAI/apex_rostest and repository reorganization
3 participants