Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for rosbag2::Player freeze when ctrl+c in pause mode #1002

Merged
merged 1 commit into from
May 14, 2022
Merged

Fix for rosbag2::Player freeze when ctrl+c in pause mode #1002

merged 1 commit into from
May 14, 2022

Conversation

MichaelOrlov
Copy link
Contributor

@MichaelOrlov MichaelOrlov commented May 10, 2022 •
edited
Loading

Fix for rosbag2::Player freeze when ctrl+c in pause mode
Addressing bug report #1000
Signed-off-by: Michael Orlov michael.orlov@apex.ai

@MichaelOrlov
Fix for rosbag2::Player freeze when ctrl+c in pause mode
daf0949 
Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
@MichaelOrlov MichaelOrlov requested a review from a team as a code owner May 10, 2022 00:36
@MichaelOrlov MichaelOrlov requested review from emersonknapp and jhdcs and removed request for a team May 10, 2022 00:36
@MichaelOrlov MichaelOrlov mentioned this pull request May 10, 2022
Closed
@MichaelOrlov
Copy link
Contributor Author

Running CI:
BUILD args: --packages-up-to rosbag2_transport rosbag2_tests
TEST args: --packages-select rosbag2_transport rosbag2_tests
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/10291/

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@MichaelOrlov
Copy link
Contributor Author

Windows build fails with some infrastructure related error:

Finished <<< ament_uncrustify [4.67s]
Starting >>> ament_cmake_uncrustify
FATAL: command execution failed

Build step 'Execute Windows batch command' marked build as failure
ERROR: Step �Record compiler warnings and static analysis results� aborted due to exception: 
java.io.IOException: No workspace found for ci_windows #17093

Trying to re-run it one more time

  • Windows Build Status

@MichaelOrlov MichaelOrlov merged commit c5f01e2 into master May 14, 2022
@delete-merged-branch delete-merged-branch bot deleted the morlov/fix-for-player-freeze-after-ctrl+c-in-pause branch May 14, 2022 17:25
MichaelOrlov added a commit that referenced this pull request May 14, 2022
@MichaelOrlov
Fix for rosbag2::Player freeze when ctrl+c in pause mode (#1002)
5ee2e9b 
Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
(cherry picked from commit c5f01e2)
@MichaelOrlov MichaelOrlov mentioned this pull request May 14, 2022
Merged
MichaelOrlov added a commit that referenced this pull request May 17, 2022
@MichaelOrlov
Fix for rosbag2::Player freeze when ctrl+c in pause mode (#1002) (#1016)
b32981c 
Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
(cherry picked from commit c5f01e2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhdcs jhdcs jhdcs approved these changes

@emersonknapp emersonknapp Awaiting requested review from emersonknapp emersonknapp is a code owner automatically assigned from ros2/tooling-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ros2 bag can't be shut down with ctrl + c when the bag is paused
2 participants
@MichaelOrlov @jhdcs