New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/split by time #1022
Fix/split by time #1022
Conversation
c0ff2b8
to
5b5a940
Compare
Thank you for your submission! However, there appear to be some linting and build errors. Could you take a quick look at them and see what's going on? |
Sorry I tried to look at the output of the job, but it's just too much to look at. Also it seems totally unrelated to the code changes I did and more about the setup of the job. For example the first error I find when searching for error is:
which are totally unrelated to the changes I made. There are also a bunch of other errors and somehow there is no option to scroll to the bottom of the log? I was scrolling for a good few minutes until I reached line 110000 or so, but still wasn't at the end. So I would be happy if somebody could have a look at why the the job is failing or maybe point me to some resources how to diagnose better what the problem is. Because having just one huge scrollable thousands of lines output file to go trough is unpractical. Is there a way to make the job stop on the first error it encounters, like colcon works in the terminal? Or is there a way to jump to the end of the output? |
1 similar comment
Sorry I tried to look at the output of the job, but it's just too much to look at. Also it seems totally unrelated to the code changes I did and more about the setup of the job. For example the first error I find when searching for error is:
which are totally unrelated to the changes I made. There are also a bunch of other errors and somehow there is no option to scroll to the bottom of the log? I was scrolling for a good few minutes until I reached line 110000 or so, but still wasn't at the end. So I would be happy if somebody could have a look at why the the job is failing or maybe point me to some resources how to diagnose better what the problem is. Because having just one huge scrollable thousands of lines output file to go trough is unpractical. Is there a way to make the job stop on the first error it encounters, like colcon works in the terminal? Or is there a way to jump to the end of the output? |
6a29594
to
639ebad
Compare
If you click "Details" on the failing test ( On the page that you will arrive to, look on the left side of the screen again. Just below the "Previous Build" button, there will be a list of links labeled "Console Sections". You will want to click on each that says The |
639ebad
to
0307845
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Kaju-Bubanja Thanks for your PR.
Overall looks good among a nitpick with uncrustify linter error.
I also found one more bug related to the bag split during review.
We are not initializing file_info.starting_time
to maximum in void SequentialWriter::split_bagfile()
.
And further on we will try to compare it with current message timestamp in line 311 of write method
According to the https://www.enseignement.polytechnique.fr/informatique/INF478/docs/Cpp/en/cpp/chrono/time_point/time_point.html default constructor for time_point, creates a time_point with a value of Clock's epoch. Which is going to be always less than time stamp from current message.
Could you please add initialization
file_info.starting_time =
std::chrono::time_point<std::chrono::high_resolution_clock>(std::chrono::nanoseconds::max());
32fd513
to
6a279ad
Compare
Thanks for the review, should be all addressed now. Currently 2 tests are failing, which seem unrelated to the PR: https://build.ros2.org/job/Rpr__rosbag2__ubuntu_jammy_amd64/118/testReport/ Not sure what the problem is with these tests |
I confirm that failing |
style: fix diff style: remove additional spaces style: typo fix: added missing input parameter refactor: make variable private refactor: fix linting error fix: Add missing initialization style: linter refactor: invert logic Signed-off-by: Kaju Bubanja <bubanja.kaju@gmail.com>
6a279ad
to
9632d40
Compare
Running CI: |
@Kaju-Bubanja Thanks for your PR one more time. |
style: fix diff style: remove additional spaces style: typo fix: added missing input parameter refactor: make variable private refactor: fix linting error fix: Add missing initialization style: linter refactor: invert logic Signed-off-by: Kaju Bubanja <bubanja.kaju@gmail.com>
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Fix #966