Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The description of --ignore-leaf-topics doesn't match the implementation #1343

Closed
Barry-Xu-2018 opened this issue May 22, 2023 · 4 comments
Closed
Labels
bug Something isn't working

Comments

@Barry-Xu-2018
Copy link
Contributor

Barry-Xu-2018 commented May 22, 2023

Description

The description of --ignore-leaf-topics doesn't much the implementation

--ignore-leaf-topics  Ignore topics without a publisher.

The implementation of check function is

bool
is_leaf_topic(
const std::string & topic_name, rclcpp::node_interfaces::NodeGraphInterface & node_graph)
{
auto subscriptions_info = node_graph.get_subscriptions_info_by_topic(topic_name);
return subscriptions_info.size() == 0;
}

So I think the description should be Ignore topics without a subscription

System (please complete the following information)

  • OS: Ubuntu Jammy
  • ROS 2 Distro: rolling
  • Version: rolling branch
@fujitatomoya
Copy link
Contributor

OS: Ubuntu Bionic

Should be Jammy? since the issue is detected with rolling?

@Barry-Xu-2018
Copy link
Contributor Author

Should be Jammy? since the issue is detected with rolling?

Yes. OS is Jammy. I will fix it.
Thank you for your reminder !

@Barry-Xu-2018
Copy link
Contributor Author

I close this issue, since the fix #1344 has already been merged.

@MichaelOrlov
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants