Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Humble] Deconstruct compression classloader factory in correct order with classes loaded #1362

Merged
merged 1 commit into from May 31, 2023

Conversation

emersonknapp
Copy link
Collaborator

@emersonknapp emersonknapp commented May 31, 2023

Manual backportable version of #1299
Closes #1278

…sses loaded

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
@emersonknapp emersonknapp force-pushed the emersonknapp/fix-classloader-warning branch from e172fed to f207c56 Compare May 31, 2023 00:30
Copy link
Contributor

@MichaelOrlov MichaelOrlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@emersonknapp
Copy link
Collaborator Author

Gist: https://gist.githubusercontent.com/emersonknapp/2f8dc59f5cb19d770007bc7d1893ee70/raw/da52b54df8bdf3f1330a7ba1abc3a3e38fda585a/ros2.repos
BUILD args: --packages-above-and-dependencies rosbag2_compression
TEST args: --packages-above rosbag2_compression
ROS Distro: humble
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/12144

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@emersonknapp emersonknapp merged commit 63d2be2 into humble May 31, 2023
14 checks passed
@delete-merged-branch delete-merged-branch bot deleted the emersonknapp/fix-classloader-warning branch May 31, 2023 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants