writer interface #205
Merged
writer interface #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anas Abou Allaban <allabana@amazon.com> Introduce new SequentialReader interface Signed-off-by: Anas Abou Allaban <allabana@amazon.com> Introduce new SequentialReader interface Signed-off-by: Anas Abou Allaban <allabana@amazon.com> Introduce new SequentialReader interface Signed-off-by: Anas Abou Allaban <allabana@amazon.com>
- Rewrite history - Move sequential reader implementation to header/source - Change namespaces - Linting Signed-off-by: Anas Abou Allaban <allabana@amazon.com>
Signed-off-by: Anas Abou Allaban <allabana@amazon.com>
Signed-off-by: Prajakta Gokhale <prajaktg@amazon.com>
Signed-off-by: Prajakta Gokhale <prajaktg@amazon.com>
* Add new reader interface * Use the interface in sequential reader Signed-off-by: Prajakta Gokhale <prajaktg@amazon.com>
Signed-off-by: Prajakta Gokhale <prajaktg@amazon.com>
* final reader class Signed-off-by: Karsten Knese <karsten@openrobotics.org> * adaptations for rosbag2_transport Signed-off-by: Karsten Knese <karsten@openrobotics.org> * address review comments Signed-off-by: Karsten Knese <karsten@openrobotics.org>
Signed-off-by: Prajakta Gokhale <prajaktg@amazon.com>
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
Signed-off-by: Prajakta Gokhale <prajaktg@amazon.com>
Signed-off-by: Anas Abou Allaban <allabana@amazon.com> Introduce new SequentialReader interface Signed-off-by: Anas Abou Allaban <allabana@amazon.com> Introduce new SequentialReader interface Signed-off-by: Anas Abou Allaban <allabana@amazon.com> Introduce new SequentialReader interface Signed-off-by: Anas Abou Allaban <allabana@amazon.com>
- Rewrite history - Move sequential reader implementation to header/source - Change namespaces - Linting Signed-off-by: Anas Abou Allaban <allabana@amazon.com>
* final reader class Signed-off-by: Karsten Knese <karsten@openrobotics.org> * adaptations for rosbag2_transport Signed-off-by: Karsten Knese <karsten@openrobotics.org> * address review comments Signed-off-by: Karsten Knese <karsten@openrobotics.org>
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
|
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
|
addressing windows warnings:
|
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
|
@prajakta-gokhale I would prefer merging this PR which also contains #191 in order to go forward. It's basically applying the same pattern to both, the reader and the writer API. Let me know what you think. |
|
LGTM. Thanks for pushing this forward! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently based on #191
@prajakta-gokhale fyi. This PR might also solve the issues encountered in your PR.
@piraka9011 You might want to adapt your "multifile reader" implementation against the API in this PR.