Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load metadata from storage if no yaml file is found #210

Merged
merged 1 commit into from
Nov 19, 2019
Merged

Conversation

Karsten1987
Copy link
Collaborator

This is necessary when loading legacy ros1 bag files, where no metadata.yaml file is present.
connected to ros2/rosbag2_bag_v2#8
Signed-off-by: Knese Karsten karsten@openrobotics.org

Signed-off-by: Knese Karsten <karsten@openrobotics.org>
@Karsten1987 Karsten1987 added the bug Something isn't working label Nov 19, 2019
@Karsten1987
Copy link
Collaborator Author

Karsten1987 commented Nov 19, 2019

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

CI with bag_v2_plugins:
Build Status

Copy link
Contributor

@piraka9011 piraka9011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zmichaels11
Copy link
Contributor

zmichaels11 commented Nov 19, 2019

Just spoke with @piraka9011
I think we should workshop this and Issue #197 since this code path exists only for rosbags written by something that isn't Writer.

@Karsten1987
Copy link
Collaborator Author

looking at the console output of the packaging job, all rosbag2 related tests passed. Merging.

@Karsten1987 Karsten1987 merged commit 08908f4 into master Nov 19, 2019
@Karsten1987 Karsten1987 deleted the fix_bag_v2 branch November 19, 2019 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants