Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compress uri #234

Merged
merged 2 commits into from
Dec 13, 2019
Merged

Fix compress uri #234

merged 2 commits into from
Dec 13, 2019

Conversation

zmichaels11
Copy link
Contributor

@zmichaels11 zmichaels11 commented Dec 13, 2019 •
edited
Loading

Issue

  • ZstdCompressor::compress_uri was writing to uri instead of compressed_uri

Changes

  • ZstdCompress::compress_uri now correctly writes to compressed_uri
  • Add check in unit test to verify the compressed file is not empty
  • Add check in unit test to verify that the compressed file exists
  • Add check in unit test to verify that the compressed_uri is not the uri

Signed-off-by: Zachary Michaels zmichaels11@gmail.com

@zmichaels11
Fix compress uri
89027ee 
Signed-off-by: Zachary Michaels <zmichaels11@gmail.com>
@zmichaels11
Add more asserts to verify problem doesnt happen again
f9a7bc7 
Signed-off-by: Zachary Michaels <zmichaels11@gmail.com>
@zmichaels11 zmichaels11 merged commit cc6cffb into ros2:master Dec 13, 2019
@zmichaels11 zmichaels11 deleted the zmichaels11/fix-compress-uri branch December 13, 2019 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piraka9011 piraka9011 piraka9011 approved these changes

@dabonnie dabonnie dabonnie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zmichaels11 @piraka9011 @dabonnie