Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[compression] Improve logging in rosbag2_compression #287

Merged
merged 1 commit into from
Feb 7, 2020
Merged

[compression] Improve logging in rosbag2_compression #287

merged 1 commit into from
Feb 7, 2020

Conversation

zmichaels11
Copy link
Contributor

@zmichaels11 zmichaels11 commented Feb 6, 2020 •
edited
Loading

Changes

  • Include uri and errno in thrown exceptions
  • Include message in EXPECT operations when EXPECT is applied to a function that consumes a URI.

Notes:

Signed-off-by: Zachary Michaels zmichaels11@gmail.com

@zmichaels11
Improve logging in rosbag2_compression
38ad729 
* Include uri and errno in thrown exceptions
* Include message in EXPECT operations when EXPECT is applied to a function that consumes a URI.

Signed-off-by: Zachary Michaels <zmichaels11@gmail.com>
piraka9011
piraka9011 approved these changes Feb 6, 2020
View reviewed changes
Copy link
Contributor

@piraka9011 piraka9011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup!

emersonknapp
emersonknapp approved these changes Feb 6, 2020
View reviewed changes
Copy link
Collaborator

@emersonknapp emersonknapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zmichaels11 zmichaels11 marked this pull request as ready for review February 6, 2020 18:27
@zmichaels11
Copy link
Contributor Author

@ros2/aws-oncall - please run this CI job
Gist: https://gist.githubusercontent.com/zmichaels11/038a90cfa31a875bdd306f26070a7e7a/raw/d28b7112c11131bd2464b77b8c81985426e88462/ros2.repos
BUILD args: --packages-up-to rosbag2_compression
TEST args: --packages-select rosbag2_compression
Job: ci_launcher

@emersonknapp
Copy link
Collaborator

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status
  • Windows-container Build Status

@zmichaels11
Copy link
Contributor Author

zmichaels11 commented Feb 6, 2020 •
edited
Loading

It looks like the macOS build failed due to the machine being pulled offline...
I've restarted the build and will edit this comment once I have a build badge.

Edit:
It looks like its going to be build 7​57​3

  • macOS Build Status

@zmichaels11 zmichaels11 mentioned this pull request Feb 7, 2020
Merged
@zmichaels11 zmichaels11 merged commit bd267ff into ros2:master Feb 7, 2020
@zmichaels11 zmichaels11 deleted the zmichaels11/improve-logging-for-compression branch February 7, 2020 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emersonknapp emersonknapp emersonknapp approved these changes

@piraka9011 piraka9011 piraka9011 approved these changes

@dabonnie dabonnie dabonnie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zmichaels11 @emersonknapp @piraka9011 @dabonnie