added rosidl_runtime c and cpp depencencies

[ahcorde]

This PR is related to the changes introduced in this PR ros2/rosidl#442. The full process can be followed here ros2/rosidl#443

Signed-off-by: ahcorde ahcorde@gmail.com

[ahcorde]

By the way, I'm not really sure why we should include this dependency here. rosidl_typesupport_cpp ( which is a dependency here ) export in the CMakeLists.txt rosidl_runtime_c/cpp but this package is not using explicitly the dependency. In this case can we remove it?

[wjwwood]

By the way, I'm not really sure why we should include this dependency here.

Just quickly searching the repo I don't see rosidl_generator_cpp either, could be that it should be removed here and just brought in as a transitive dependency implicitly.

[Karsten1987]

I could imagine it's a leftover from this change here: b4c459a

If the dependency is not being used in this repo, we should remove it.

[wjwwood]

👍 to removing it or leaving it btw, I'll leave that up to you @ahcorde and @Karsten1987.

[ahcorde]

rosbag2_converter_default_plugins

this package use rosidl_generator_cpp headers located now in rosidl_runtime_cpp

rosbag2/rosbag2_converter_default_plugins/src/rosbag2_converter_default_plugins/cdr/cdr_converter.hpp

Line 23 in ec4fb39

#include "rosidl_generator_cpp/message_type_support_decl.hpp"

No need to ament_export_dependency the package or <exec_depend> (rosidl_runtime_cpp is not generating any .so/dll/dylib)

[ahcorde]

I have created this other PR #321 (because the change is not related with this PR) Removing rosidl_generator_cpp in rosbag2_transport because it's not been used.

[Karsten1987]

lgtm with green CI

[ahcorde]

• Updated all repos involved in this change.
• Skipping ros1_bridge, qt_*, rqt_*, and rviz_* packages.
• Testing against test_rclcpp and rosbag2_tests.

• Linux
• Linux-aarch64
• macOS
• Windows

• One warning made the builds unstable but there is a (PR pending)

CMake Deprecation Warning at /home/jenkins-agent/workspace/ci_linux-aarch64/ws/install/ament_cmake_export_interfaces/share/ament_cmake_export_interfaces/cmake/ament_export_interfaces.cmake:37 (message):
ament_export_interfaces() is deprecated, use ament_export_targets() instead
Call Stack (most recent call first):
CMakeLists.txt:85 (ament_export_interfaces)

In MacOS

• projectroot.cppcheck

Windows

• some failures in test_rclcpp