Improve sqlite iterator interface #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reason: multiple iterators for the same query result would interfere with each other as a single result row can only be retrieved once. These side effects would be very surprising and are therefore forbidden.
|
CI
|
Karsten1987
approved these changes
Sep 18, 2018
| @@ -51,14 +51,14 @@ SqliteStatementWrapper::~SqliteStatementWrapper() | |||
| std::shared_ptr<SqliteStatementWrapper> SqliteStatementWrapper::execute_and_reset() | |||
| { | |||
| int return_code = sqlite3_step(statement_); | |||
| if (!isQueryOk(return_code)) { | |||
| if (!is_query_ok(return_code)) { | |||
There was a problem hiding this comment.
just as a remark. I know it's only single threaded for now, but I believe operations like that can benefit from atomic compare_exchange.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
SqliteStatementWrapper::QueryResult::Iteratorrepresents the result set of a sqlite query that needs to be stepped. Using a copy of such a iterator would also step the statement and looping the original iterator would "miss" result rows. To avoid this surprising behavior this PR changes the iterator interface to disable copies.