include hidden topics #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
Karsten1987
commented
Mar 26, 2020
Comment on lines
181
to
184
| ROSBAG2_TRANSPORT_LOG_ERROR_STREAM( | ||
| "Hidden topics are not recorded. Topic '" << | ||
| topic_and_type.first << "' will be skipped." << | ||
| "You can enable them with --include-hidden-topics"); |
There was a problem hiding this comment.
Since this is polled periodically, I am looking for a way to log only once. I am currently unable to find the appropriate macro, any ideas?
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
|
emersonknapp
approved these changes
Mar 26, 2020
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
|
thanks for the iteration! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #331
This change introduces a new command line option
--include-hidden-topicswhich explicitly enables the recording of hidden topics. If this option is not set, hidden topics won't be recored by default.Signed-off-by: Karsten Knese karsten@openrobotics.org