Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add user provided split size to error #430

Merged
merged 4 commits into from
Jun 3, 2020
Merged

Add user provided split size to error #430

merged 4 commits into from
Jun 3, 2020

Conversation

piraka9011
Copy link
Contributor

  • Add the user defined split size to the splitting error.
  • Address comment on catching only std::runtime_error in tests.

Signed-off-by: Anas Abou Allaban allabana@amazon.com

Add user provided split size to error
dc4c450 
Signed-off-by: Anas Abou Allaban <allabana@amazon.com>
@piraka9011
Copy link
Contributor Author

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

zmichaels11
zmichaels11 approved these changes Jun 3, 2020
View reviewed changes
Copy link
Contributor

@zmichaels11 zmichaels11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Do you need a unit test for SequentialCompressionWriter to verify it throws when bad input is passed?

@piraka9011
Copy link
Contributor Author

piraka9011 commented Jun 3, 2020 •
edited
Loading

LGTM
Do you need a unit test for SequentialCompressionWriter to verify it throws when bad input is passed?

Nope, it's already there.
It is not there. Adding.

dabonnie
dabonnie approved these changes Jun 3, 2020
View reviewed changes
Copy link
Contributor

@dabonnie dabonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice additions

Add splitting unit test
2264183 
Signed-off-by: Anas Abou Allaban <allabana@amazon.com>
@piraka9011
Copy link
Contributor Author

piraka9011 commented Jun 3, 2020 •
edited
Loading

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Missing diff
48c18d4 
Signed-off-by: Anas Abou Allaban <allabana@amazon.com>
@piraka9011
Fix test
05e7be5 
Signed-off-by: Anas Abou Allaban <aabouallaban@pm.me>
@piraka9011 piraka9011 merged commit 3e1cd8e into ros2:master Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmichaels11 zmichaels11 zmichaels11 approved these changes

@dabonnie dabonnie dabonnie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@piraka9011 @zmichaels11 @dabonnie