Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

export shared_queues_vendor #434

Merged
merged 2 commits into from
Jun 11, 2020
Merged

export shared_queues_vendor #434

merged 2 commits into from
Jun 11, 2020

Conversation

Karsten1987
Copy link
Collaborator

fixes #433

@Karsten1987 Karsten1987 self-assigned this Jun 5, 2020
@Karsten1987 Karsten1987 added this to Proposed in Foxy Patch Release 1 via automation Jun 5, 2020
@Karsten1987
Copy link
Collaborator Author

for completeness, this branch allows to compile the master branch of the rosbag2_bag_v2_plugins and thus the temporary workaround should be reverted:
https://ci.ros2.org/job/ci_packaging_linux/373/

@Karsten1987
export shared_queues_vendor
4e9b13b 
Signed-off-by: Knese Karsten <karsten@openrobotics.org>
@Karsten1987
Revert "find rosbag2_cpp (tinyxml2) before rcl (#423)"
0ad7fdd 
This reverts commit 48fd15e.
@Karsten1987
Copy link
Collaborator Author

The second commit reverts #423 (comment) as the tinyxml include order is resolved.

@Karsten1987
Copy link
Collaborator Author

Karsten1987 commented Jun 11, 2020 •
edited
Loading

build up to rosbag2, test rosbag2_transport

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@Karsten1987 Karsten1987 merged commit a617141 into master Jun 11, 2020
@delete-merged-branch delete-merged-branch bot deleted the export_queues branch June 11, 2020 20:17
Karsten1987 added a commit that referenced this pull request Jun 11, 2020
@Karsten1987
export shared_queues_vendor (#434)
cf76871 
* export shared_queues_vendor

Signed-off-by: Knese Karsten <karsten@openrobotics.org>

* Revert "find rosbag2_cpp (tinyxml2) before rcl (#423)"

This reverts commit 48fd15e.
@Karsten1987 Karsten1987 removed this from Proposed in Foxy Patch Release 1 Jun 11, 2020
@Karsten1987 Karsten1987 mentioned this pull request Jun 11, 2020
Merged
Karsten1987 added a commit that referenced this pull request Jun 17, 2020
@Karsten1987
export shared_queues_vendor (#434)
09f62b1 
* export shared_queues_vendor

Signed-off-by: Knese Karsten <karsten@openrobotics.org>

* Revert "find rosbag2_cpp (tinyxml2) before rcl (#423)"

This reverts commit 48fd15e.

Signed-off-by: Karsten Knese <karsten@openrobotics.org>
Karsten1987 added a commit that referenced this pull request Jun 17, 2020
@Karsten1987
export shared_queues_vendor (#434) (#438)
4acab90 
* export shared_queues_vendor

Signed-off-by: Knese Karsten <karsten@openrobotics.org>

* Revert "find rosbag2_cpp (tinyxml2) before rcl (#423)"

This reverts commit 48fd15e.

Signed-off-by: Karsten Knese <karsten@openrobotics.org>
adamdbrw pushed a commit to RobotecAI/rosbag2 that referenced this pull request Aug 4, 2020
@Karsten1987 @adamdbrw
export shared_queues_vendor (ros2#434)
dfb5d06 
* export shared_queues_vendor

Signed-off-by: Knese Karsten <karsten@openrobotics.org>

* Revert "find rosbag2_cpp (tinyxml2) before rcl (ros2#423)"

This reverts commit 48fd15e.
emersonknapp pushed a commit that referenced this pull request Feb 2, 2021
@Karsten1987
export shared_queues_vendor (#434)
e15ba2e 
* export shared_queues_vendor

Signed-off-by: Knese Karsten <karsten@openrobotics.org>

* Revert "find rosbag2_cpp (tinyxml2) before rcl (#423)"

This reverts commit 48fd15e.
emersonknapp pushed a commit that referenced this pull request Feb 17, 2021
@Karsten1987
export shared_queues_vendor (#434)
5d34d61 
* export shared_queues_vendor

Signed-off-by: Knese Karsten <karsten@openrobotics.org>

* Revert "find rosbag2_cpp (tinyxml2) before rcl (#423)"

This reverts commit 48fd15e.

Signed-off-by: Emerson Knapp <eknapp@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirk-thomas dirk-thomas dirk-thomas approved these changes

@emersonknapp emersonknapp Awaiting requested review from emersonknapp

Assignees

@Karsten1987 Karsten1987

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[rosbag2_transport] export shared_queues_vendor
2 participants
@Karsten1987 @dirk-thomas