Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract recorder from rosbag2_transport, fix test naming #44

Merged
merged 1 commit into from
Oct 17, 2018
Merged

Extract recorder from rosbag2_transport, fix test naming #44

merged 1 commit into from
Oct 17, 2018

Conversation

greimela-si
Copy link
Contributor

@greimela-si greimela-si commented Oct 11, 2018 •
edited
Loading

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@greimela-si greimela-si mentioned this pull request Oct 11, 2018
Closed
Karsten1987
Karsten1987 reviewed Oct 15, 2018
View reviewed changes
rosbag2_transport/src/rosbag2_transport/recorder.cpp Outdated
}

ROSBAG2_TRANSPORT_LOG_INFO("Subscription setup complete.");
while (rclcpp::ok()) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also this was changed before. Please make sure to really only shift around existing code. Otherwise we have to re-review everything.

Karsten1987
Karsten1987 requested changes Oct 15, 2018
View reviewed changes
Copy link
Collaborator

@Karsten1987 Karsten1987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this PR introduces old code, I believe.

@Martin-Idel-SI
Copy link
Contributor

New CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@Karsten1987 Karsten1987 merged commit 509cd4c into ros2:master Oct 17, 2018
@Martin-Idel-SI Martin-Idel-SI deleted the feature/cleanup branch October 18, 2018 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Karsten1987 Karsten1987 Karsten1987 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@greimela-si @Martin-Idel-SI @Karsten1987 @tfoote