fix missing target dependencies #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
emersonknapp
approved these changes
Jul 31, 2020
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
|
I just also added an explicit dependency on |
|
If the PR builds are green I would suggest merging this since the CI builds from ci.ros2.org won't provide any more information. The actual change can only be tested with an overlay workspace. |
|
I can confirm that this solves the issue. The packages within rosbag2 can be built correctly in an overlay workspace. |
Karsten1987
pushed a commit
that referenced
this pull request
Jul 31, 2020
* fix missing target dependencies Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com> * also avoid relying on transitive dependencies Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
Karsten1987
added a commit
that referenced
this pull request
Jul 31, 2020
* fix missing target dependencies Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com> * also avoid relying on transitive dependencies Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com> Co-authored-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix build failure reported in https://answers.ros.org/question/358314/colcon-build-include-path-from-overlay-workspace/.