Do not expect empty StorageOptions URI to work in *CompressionWriterTest #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophebedard
requested review from
emersonknapp and
jaisontj
and removed request for
a team
|
|
Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
christophebedard
force-pushed
the
rosbag2-compression-writer-test-fix-create-directories-with-empty-string
branch
from
7b129ec
to
4dd6af9
Compare
fujitatomoya
approved these changes
Sep 26, 2020
| std::move(metadata_io_)); | ||
| writer_ = std::make_unique<rosbag2_cpp::Writer>(std::move(sequential_writer)); | ||
|
|
||
| EXPECT_THROW( |
There was a problem hiding this comment.
http://build.ros2.org/job/Rpr__rosbag2__ubuntu_focal_amd64/209/testReport/rosbag2_compression/SequentialCompressionWriterTest/open_throws_on_empty_storage_options_uri/, currently this is expected to fail unless ros2/rcpputils#95 is merged.
|
@emersonknapp / @jaisontj could you take a look at this? It's needed for other PRs. |
emersonknapp
approved these changes
Oct 1, 2020
|
CI is at ros2/rcpputils#98 (comment) |
|
CI passed (see ros2/rcpputils#98 (comment)), merging together with ros2/rcpputils#98. (I will release the rcpputils repo to make the PR checker pass again) |
christophebedard
deleted the
rosbag2-compression-writer-test-fix-create-directories-with-empty-string
branch
emersonknapp
pushed a commit
that referenced
this pull request
Feb 2, 2021
…est (#526) Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
emersonknapp
pushed a commit
that referenced
this pull request
Feb 17, 2021
…est (#526) Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
skudryas
pushed a commit
to skudryas/rosbag2
that referenced
this pull request
Mar 12, 2021
…est (ros2#526) Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For ros2/rcpputils#94, I proposed ros2/rcpputils#95, which made it so that
rcpputils::fs::create_directories()returns false if the directory path is invalid, e.g. if the path is empty, invalid, not a directory, etc.This was the case for
SequentialCompressionWriterTest, which assumed that using an emptyrosbag2_cpp::StorageOptionsURI would work. That test then started failing and ros2/rcpputils#95 was reverted. This PR changesSequentialCompressionWriterTestso that ros2/rcpputils#95 can be merged back in.See ros2/rcpputils#97 (review)