Remove some code duplication between SequentialWriter and SequentialCompressionWriter #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
from SequentialWriter. Created a new function prepare_to_open in SequentialWriter to reuse code with SequentialCompressionWriter Signed-off-by: Jaison Titus <jaisontj@amazon.com>
jaisontj
changed the title
emersonknapp
approved these changes
Oct 1, 2020
dabonnie
reviewed
Oct 1, 2020
rosbag2_compression/src/rosbag2_compression/sequential_compression_writer.cpp
Show resolved
Hide resolved
get_writeable_message which performs the operations on messages before writing it to storage or cache. Signed-off-by: Jaison Titus <jaisontj@amazon.com>
emersonknapp
reviewed
Oct 1, 2020
rosbag2_compression/src/rosbag2_compression/sequential_compression_writer.cpp
Outdated
Show resolved
Hide resolved
dabonnie
suggested changes
Oct 1, 2020
@dabonnie The new methods are non public and used internally as helper methods. Do we usually write unit tests for those? |
|
No, generally you unit test the public interface, not the implementation details (private methods). You can of course unit test protected methods by making a test-specific subclass of the given class, but that depends on how much you consider it an interface surface vs an implementation detail. |
overriding open Signed-off-by: Jaison Titus <jaisontj@amazon.com>
which open worked inside compressionwriter does not really matter Signed-off-by: Jaison Titus <jaisontj@amazon.com>
jaisontj
force-pushed
the
jaisontj/refactor-write
branch
from
a28670d
to
23f1281
Compare
dabonnie
approved these changes
Oct 1, 2020
|
emersonknapp
pushed a commit
that referenced
this pull request
Feb 2, 2021
…ompressionWriter (#527) Remove code duplication between SequentialWriter and SequentialCompressionWriter Signed-off-by: Jaison Titus <jaisontj@amazon.com>
emersonknapp
pushed a commit
that referenced
this pull request
Feb 17, 2021
…ompressionWriter (#527) Remove code duplication between SequentialWriter and SequentialCompressionWriter Signed-off-by: Jaison Titus <jaisontj@amazon.com>
skudryas
pushed a commit
to skudryas/rosbag2
that referenced
this pull request
Mar 12, 2021
…ompressionWriter (ros2#527) Remove code duplication between SequentialWriter and SequentialCompressionWriter Signed-off-by: Jaison Titus <jaisontj@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Edited] Major changes:
SequentialCompressionWriternow inherits fromSequentialWriterget_writeable_messageinside ofSequentialWriterto be called to get the message to be written to storage or cache