Performance benchmarking improvements #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Piotr Jaroszek <piotr.jaroszek@robotec.ai>
pijaro
requested review from
emersonknapp and
prajakta-gokhale
and removed request for
a team
Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>
emersonknapp
reviewed
Feb 4, 2021
rosbag2_performance/rosbag2_performance_benchmarking/launch/benchmark_launch.py
Show resolved
Hide resolved
emersonknapp
reviewed
Feb 4, 2021
rosbag2_performance/rosbag2_performance_benchmarking/launch/benchmark_launch.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Piotr Jaroszek <piotr.jaroszek@robotec.ai>
|
@emersonknapp is this good to be merged? |
delete-merged-branch
bot
deleted the
performance_benchmarking_improvements
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small pack of few quality of life improvements and one fix for performance benchmarking:
ros2 bag recordto properly use new--regexsyntax (-awhich is used currently causing sometimes over 100% recorded output when unnecessary topics like/rosoutare recorded),report_gen.pytool additionally returns "min" and "max" percents of recorded messages, not only average.