CLI query rosbag2_py for available storage implementations #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
February 16, 2021 14:33
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
emersonknapp
requested review from
Karsten1987 and
jaisontj
and removed request for
a team
added 2 commits
February 16, 2021 16:12
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
jaisontj
approved these changes
Feb 17, 2021
|
Gist: https://gist.githubusercontent.com/emersonknapp/3703551fdccf1ae2ed4375c689a69a77/raw/d73743204ec4eff47d122c11530a940ab9fdec59/ros2.repos
|
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
prajakta-gokhale
approved these changes
Mar 3, 2021
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
|
prajakta-gokhale
approved these changes
Mar 3, 2021
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
ros2 bag record/play, query the python API for which storage implementations are available.Prefer
sqlite3as the default, but only if it is found. Otherwise default to the first storage implementation found.I plan to use this same pattern for converters/compressors.