Enable thread safety analysis for rosbag2_cpp and add annotations in TimeControllerClock #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…TimeControllerClock Signed-off-by: Emerson Knapp <eknapp@amazon.com>
emersonknapp
requested review from
jaisontj and
prajakta-gokhale
and removed request for
a team
david-prody
approved these changes
Apr 5, 2021
prajakta-gokhale
approved these changes
Apr 5, 2021
50 tasks
|
Gist: https://gist.githubusercontent.com/emersonknapp/08803d7b3f5e9838b4eed77539196fdd/raw/48f9277a205891b8db6c79111b4a8921dc1c3ff0/ros2.repos
|
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
emersonknapp
force-pushed
the
emersonknapp/playerclock-thread-safety-tweaks
branch
2 times, most recently
from
a8dd150
to
cb3386f
Compare
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
emersonknapp
force-pushed
the
emersonknapp/playerclock-thread-safety-tweaks
branch
from
cb3386f
to
e2ab944
Compare
|
Trying another way that is more obvious in usage, and should also be Windows-friendly
|
delete-merged-branch
bot
deleted the
emersonknapp/playerclock-thread-safety-tweaks
branch
Kettenhoax
pushed a commit
to Kettenhoax/rosbag2
that referenced
this pull request
Apr 9, 2021
…TimeControllerClock (ros2#710) * Enable thread safety analysis for rosbag2_cpp and add annotations in TimeControllerClock Signed-off-by: Emerson Knapp <eknapp@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address after-merge comments from @MichaelOrlov in #689 (review)