Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add set_rate to PlayerClock #727

Merged
merged 2 commits into from
Apr 13, 2021

Conversation

emersonknapp
Copy link
Collaborator

Implements the feature to change playback rate while running

Part of #696

@emersonknapp emersonknapp changed the base branch from master to emersonknapp/player-clock-pause-resume April 9, 2021 19:55
@emersonknapp emersonknapp changed the title Add set_rate to PlayerClock [WIP] Add set_rate to PlayerClock Apr 9, 2021
@delete-merged-branch delete-merged-branch bot deleted the branch master April 12, 2021 18:39
@emersonknapp emersonknapp force-pushed the emersonknapp/player-clock-change-rate branch 3 times, most recently from d19064d to 1facbf5 Compare April 13, 2021 00:01
@emersonknapp emersonknapp changed the base branch from emersonknapp/player-clock-pause-resume to emersonknapp/pause-additional-test April 13, 2021 00:02
@emersonknapp emersonknapp changed the title [WIP] Add set_rate to PlayerClock Add set_rate to PlayerClock Apr 13, 2021
@emersonknapp emersonknapp marked this pull request as ready for review April 13, 2021 00:02
@emersonknapp emersonknapp requested a review from a team as a code owner April 13, 2021 00:02
@emersonknapp emersonknapp requested review from jaisontj, piraka9011 and prajakta-gokhale and removed request for a team April 13, 2021 00:02
@delete-merged-branch delete-merged-branch bot deleted the branch master April 13, 2021 00:11
@emersonknapp emersonknapp changed the base branch from emersonknapp/pause-additional-test to master April 13, 2021 00:29
@emersonknapp emersonknapp force-pushed the emersonknapp/player-clock-change-rate branch from 1facbf5 to 459c2a9 Compare April 13, 2021 00:30
Emerson Knapp added 2 commits April 12, 2021 18:22
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
@emersonknapp emersonknapp force-pushed the emersonknapp/player-clock-change-rate branch from 459c2a9 to 44047fb Compare April 13, 2021 01:23
@emersonknapp
Copy link
Collaborator Author

Gist: https://gist.githubusercontent.com/emersonknapp/5009b6ddc40598664a1dd92d52aff43b/raw/8d5251e681f0086ea9df8db8f761ceb096cc92d0/ros2.repos
BUILD args: --packages-up-to rosbag2_cpp
TEST args: --packages-select rosbag2_cpp
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/8223

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@emersonknapp emersonknapp merged commit 5f77e8f into master Apr 13, 2021
@emersonknapp emersonknapp deleted the emersonknapp/player-clock-change-rate branch October 19, 2021 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants