Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce non-null now_fn in TimeControllerClock #731

Merged
merged 1 commit into from
Apr 13, 2021
Merged

Enforce non-null now_fn in TimeControllerClock #731

merged 1 commit into from
Apr 13, 2021

Conversation

emersonknapp
Copy link
Collaborator

Instead of raising std::bad_function on first use, raise std::invalid_argument in the constructor

@emersonknapp emersonknapp requested a review from a team as a code owner April 12, 2021 23:25
@emersonknapp emersonknapp requested review from Karsten1987 and zmichaels11 and removed request for a team April 12, 2021 23:25
@emersonknapp emersonknapp mentioned this pull request Apr 12, 2021
Merged
david-prody
david-prody approved these changes Apr 12, 2021
View reviewed changes
Copy link

@david-prody david-prody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Enforce non-null now_fn in TimeControllerClock
ab7c916 
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
@emersonknapp
Copy link
Collaborator Author

Gist: https://gist.githubusercontent.com/emersonknapp/8d38ee6b29c6b424357a9086938613ec/raw/956e07ec89e5fc417ad10fafde15dbd9d94c92cf/ros2.repos
BUILD args: --packages-up-to rosbag2_cpp
TEST args: --packages-select rosbag2_cpp
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/8210

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@emersonknapp emersonknapp mentioned this pull request Apr 13, 2021
Closed
50 tasks
@emersonknapp emersonknapp merged commit 453281c into master Apr 13, 2021
@delete-merged-branch delete-merged-branch bot deleted the emersonknapp/assert-now-fn branch April 13, 2021 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmichaels11 zmichaels11 zmichaels11 approved these changes

@david-prody david-prody david-prody approved these changes

@Karsten1987 Karsten1987 Awaiting requested review from Karsten1987

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@emersonknapp @zmichaels11 @david-prody