remove rosbag2_transport header

[Karsten1987]

as per title, finally triggering the switch.

sits on top of #741

[Karsten1987]

• Linux
• Linux-aarch64
• macOS
• Windows

[emersonknapp]

Don't you want to start spinning before calling record? IIRC record doesn't exit until it's cancelled.

[Karsten1987]

hmm. I honestly don't know. I had the same question at #741 within the tests - this code is actually really just copied from these.
I thought it would make sense to give record the change to setup all subscriptions and potential error handling and really only spin once that's completed.

Why do you advocate for spinning first?

[emersonknapp]

Oh - Recorder::record returns right away after setup and runs in the background, until the Recorder object is destroyed. API confusion from the previous blocking API.

Not something we have to handle here, but maybe we ought to consider a slightly more obvious API - if recording is controlled by the object lifecycle, then should recording just start in the constructor? Or, alternatively should there be a way to stop recording without destroying the object?

[emersonknapp]

Now that we are making these public I think we need a serious docstring pass. Not blocking this, but we should make an effort to document every public header in the "cleanup sprint"

[Karsten1987]

• Linux
• Linux-aarch64
• macOS
• Windows

[Karsten1987]

@Emerson, could it be that the GH actions don't observe the xfail label?
There seems to be a discrepancy between the CI buildfarm results and the actions.

As a side note, I believe there's simply a bug in the record_end_to_end test. We expect a positive exit code, yet the command is clearly invoked incorrectly. So the system actually behaves correctly, the test is wrong in my opinion.

[emersonknapp]

could it be that the GH actions don't observe the xfail label?

That's correct - it is not configured out of the box to do anything specific about xfail - that's something we could configure for this specific repo, or we could make it a default behavior. I'm more inclined to allow it to be configured on a per-repo basis - given that it's not "built-in" to the Jenkins jobs, it's just prepopulated build args --ctest-args -LE xfail --pytest-args -m "not xfail"

[emersonknapp]

#748