Handle SIGTERM gracefully in recording #792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emersonknapp
force-pushed
the
emersonknapp/handle-sigterm
branch
from
9896c99
to
93c3b2d
Compare
|
Windows Trying it out for build - there is not an expectation that the regression test will fail. |
emersonknapp
force-pushed
the
emersonknapp/handle-sigterm
branch
3 times, most recently
from
dc0276d
to
0ff6259
Compare
emersonknapp
requested review from
mjeronimo,
jhdcs,
lihui815 and
Karsten1987
and removed request for
a team
zmichaels11
approved these changes
Jul 2, 2021
|
Gist: https://gist.githubusercontent.com/emersonknapp/2e4053ad46ac63ad5fba61b2253f7c2e/raw/1c849f3a190a25cd3bf3e3aa2d1d8dba0ff9d6af/ros2.repos
|
jikawa-az
approved these changes
Jul 2, 2021
added 5 commits
July 2, 2021 15:44
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
…ot mark as failure - gotta fix Signed-off-by: Emerson Knapp <eknapp@amazon.com>
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
emersonknapp
force-pushed
the
emersonknapp/handle-sigterm
branch
from
0ff6259
to
fb3e3d1
Compare
|
Windows rebuild |
emersonknapp
added a commit
that referenced
this pull request
Jul 3, 2021
* Handle SIGTERM gracefully in recording Signed-off-by: Emerson Knapp <eknapp@amazon.com>
This was referenced Jul 3, 2021
emersonknapp
added a commit
that referenced
this pull request
Jul 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #791
Allow for graceful shutdown (e.g. create
metadata.yml) on SIGTERM, the same way we do on Ctrl+C/SIGINT.I've added the signal handler into the
rosbag2_pylayer that acts as the main C-side entrypoint for the process, on the assumption that this feature is desirable for the commandline tool and that, if therosbag2_transport::Recorderis used in other contexts, they may or may not want to handle SIGTERM in the same way.