Move notification about ready for playback inside play_messages_from_… #832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…queue() Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
MichaelOrlov
requested review from
zmichaels11,
jhdcs,
emersonknapp and
Karsten1987
and removed request for
a team
jhdcs
approved these changes
Jul 30, 2021
|
Gist: |
delete-merged-branch
bot
deleted the
fix-for-concurrent-call-to-msg-queue-seek-api
branch
camm73
pushed a commit
to camm73/rosbag2
that referenced
this pull request
Aug 6, 2021
…queue() (ros2#832) Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Signed-off-by: Cameron Miller <cammlle@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move notification that player ready for playback inside play_messages_from_queue() after peeking pointer to the next message.
The rational is that
moodycamel::ReaderWriterQueue::peek()is not allowed to be called from more than one thread concurrently.Please see more details in #828 (comment)
Option with protecting
Player::peek_next_message_from_queue()by mutex is highly undesirable since it would affect performance in case we would have messages recorded with high frequency and substantial amount of payload.We are fine with current workaround since it will be only one thread accessing
Player::peek_next_message_from_queue()by design.