Fix record test to reflect plugin query changes #838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camm73
requested review from
mjeronimo and
prajakta-gokhale
and removed request for
a team
Signed-off-by: Cameron Miller <cammlle@amazon.com>
camm73
force-pushed
the
cameron/fix-record-end-to-end-test
branch
from
50f026e
to
213898b
Compare
emersonknapp
approved these changes
Aug 5, 2021
|
WJaworskiRobotec
pushed a commit
to RobotecAI/rosbag2
that referenced
this pull request
Sep 12, 2021
Signed-off-by: Cameron Miller <cammlle@amazon.com> Signed-off-by: Wojciech Jaworski <wojciech.jaworski@robotec.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
record_fails_gracefully_if_plugin_for_given_encoding_does_not_existwas failing due to plugin query added in #827