Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metadata per file info #870

Merged
merged 2 commits into from
Oct 14, 2021
Merged

Metadata per file info #870

merged 2 commits into from
Oct 14, 2021

Conversation

WJaworskiRobotec
Copy link
Contributor

No description provided.

@WJaworskiRobotec WJaworskiRobotec requested a review from a team as a code owner September 12, 2021 20:41
@WJaworskiRobotec WJaworskiRobotec requested review from emersonknapp and lihui815 and removed request for a team September 12, 2021 20:41
@WJaworskiRobotec
added per-file info to metadata.yaml
5655b13 
Signed-off-by: Wojciech Jaworski <wojciech.jaworski@robotec.ai>
@WJaworskiRobotec
test files for new metadata format
86d2887 
Signed-off-by: Wojciech Jaworski <wojciech.jaworski@robotec.ai>
@WJaworskiRobotec WJaworskiRobotec mentioned this pull request Sep 12, 2021
Closed
@WJaworskiRobotec
Copy link
Contributor Author

@emersonknapp please review this one (cleaned version)

@WJaworskiRobotec
Copy link
Contributor Author

@emersonknapp or @lihui815 could you please review this PR ?

@emersonknapp
Copy link
Collaborator

Thanks for the patch - sorry for the slow review

@emersonknapp
Copy link
Collaborator

Gist: https://gist.githubusercontent.com/emersonknapp/c3b5435cade42a90258441500d89302c/raw/1703ea2ad832bf8049e9b773823d741c9125064d/ros2.repos
BUILD args: --packages-up-to rosbag2_cpp rosbag2_py rosbag2_storage rosbag2 rosbag2_tests
TEST args: --packages-select rosbag2_cpp rosbag2_py rosbag2_storage rosbag2 rosbag2_tests
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/9175

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@emersonknapp emersonknapp merged commit 4615fba into ros2:master Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emersonknapp emersonknapp emersonknapp approved these changes

@lihui815 lihui815 Awaiting requested review from lihui815

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@WJaworskiRobotec @emersonknapp