Need to pass introspection TS to converter plugin for it to be useful #896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
emersonknapp
requested review from
mjeronimo and
lihui815
and removed request for
a team
lihui815
approved these changes
Oct 27, 2021
|
Gist: https://gist.githubusercontent.com/emersonknapp/61fa119284ac020e3cc59b5cfc34893d/raw/1600028b1de6835d4cc4d589abcca6c1a3e42718/ros2.repos
|
delete-merged-branch
bot
deleted the
emersonknapp/converter-needs-introspection-ts
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nobody (that I know of) actually uses this function signature argument
rosbag2_bag_v2implements a deserializer, which does not use the passed in typesupport objectrosbag2_converter_yamlrevealed that a meaningful implementation of a Converter would need introspection information, so we might as well just start passing this in. It doesn't change the API/ABI, only the underlying data within the passed argument.