Bugfix for broken bag split when using cache #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `start()` method to the `CacheConsumer` class and call it from `sequential_writer` after split. Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
|
This looks like a regression to me, likely introduced with the snapshot feature. Cache consumer worked with bag splitting without the need to explicitly start it previously. This was guaranteed by |
adamdbrw
approved these changes
Dec 14, 2021
hidmic
reviewed
Dec 15, 2021
rosbag2_compression/test/rosbag2_compression/test_sequential_compression_writer.cpp
Outdated
Show resolved
Hide resolved
…rTest writer_creates_correct_metadata_relative_filepaths since logic for split has been changed. Now it will be fair. If specified max_baf_file_size = 1 it will be reasonable to expect only one message per file. Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
MichaelOrlov
force-pushed
the
morlov/bugfix_for_broken_split
branch
from
f9bd788
to
9eb66e1
Compare
|
Running CI
|
Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
|
Rerun CI for Windows after trying to fix typecast warning in test.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
start()method to theCacheConsumerclass and call it fromsequential_writerafter split. Also added unit test to cover cases when bag splitting with enabled cache.