Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rosbag2 metapackage #16

Merged
merged 4 commits into from
Jan 21, 2020
Merged

Conversation

zmichaels11
Copy link
Contributor

Changes

Blocked on ros2/rosbag2#253 since play e2e test is failing.

Copy link
Contributor

@emersonknapp emersonknapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Signed-off-by: Zachary Michaels <zmichaels11@gmail.com>
@zmichaels11 zmichaels11 force-pushed the zmichaels11/rosbag2_metapackage_support branch from 166bb7d to d37e509 Compare January 14, 2020 23:58
Signed-off-by: Zachary Michaels <zmichaels11@gmail.com>
@zmichaels11 zmichaels11 marked this pull request as ready for review January 15, 2020 00:06
Signed-off-by: Zachary Michaels <zmichaels11@gmail.com>
@zmichaels11
Copy link
Contributor Author

zmichaels11 commented Jan 15, 2020

@Karsten1987 does this PR need CI to merge?
Dpr and Epr are failing due to unrelated changes.

@Karsten1987
Copy link
Contributor

The same comment applies here: ros2/rosbag2#254 (comment)

Signed-off-by: Zachary Michaels <zmichaels11@gmail.com>
@zmichaels11
Copy link
Contributor Author

zmichaels11 commented Jan 16, 2020

Building with ci_packaging
Repos file https://gist.githubusercontent.com/zmichaels11/543a323a0b3788054a44899fc4eecfd5/raw/b983d85e735c80a1cca3ab36e3a3ae2839c07224/ros2.repos
CI Build Args --event-handlers console_cohesion+ console_package_list+ --cmake-args -DINSTALL_EXAMPLES=OFF -DSECURITY=ON --packages-up-to rosbag2_bag_v2_plugins
CI_MIXED_ROS_OVERLAY_PKGS ros1_bridge rosbag2_bag_v2_plugins ros1_rosbag_storage_vendor
CI Test Args --event-handlers console_direct+ --executor sequential --retest-until-pass 10 --packages-select rosbag2_bag_v2_plugins

Build status

  • Linux Build Status
  • Linux ARM64 Build Status
  • macOS Build Status
  • Windows Build Status

@zmichaels11
Copy link
Contributor Author

All tests passed on Linux CI, going to kick off CI for other OS's

@zmichaels11
Copy link
Contributor Author

I ran CI with packaging on all OS.
Linux and Linux ARM64 are running properly. They're marked unstable due to a deprecation warning in ros1_bridge: "Package 'actionlib_msgs' is deprecated"

macOS packaging reports as passing, however it stopped after building the underlay.
Windows packagin reports as unstable and didn't finish building the underlay. (It didn't `packages-skip ros1_bridge like Linux/Linux ARM64 did)

@Karsten1987 what do you think should be done?

Copy link
Contributor

@Karsten1987 Karsten1987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me. For specifically this plugin, we don't have to care too much for MacOS and Windows as I doubt they every come out clean.

For the linux ones, the tests for the bag_v2 run and pass, so that's really what matters here IMO.

@zmichaels11 zmichaels11 merged commit cda8313 into master Jan 21, 2020
@zmichaels11 zmichaels11 deleted the zmichaels11/rosbag2_metapackage_support branch January 21, 2020 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants