Skip to content
This repository has been archived by the owner on Jan 11, 2019. It is now read-only.

Reference ardent version for source repo #262

Merged
merged 4 commits into from Aug 14, 2018
Merged

Reference ardent version for source repo #262

merged 4 commits into from Aug 14, 2018

Conversation

dhood
Copy link
Member

@dhood dhood commented Aug 14, 2018

Looking for confirmation this is a reasonable thing to do before doing so for other repos.

Otherwise, for example, the version of launch on ros2index will reference the changelog off master which is incorrect.

@dhood dhood added the in review Waiting for review (Kanban column) label Aug 14, 2018
@dhood dhood self-assigned this Aug 14, 2018
@mikaelarguedas
Copy link
Member

Yeah that's fine.
As we dont run any dev job for Ardent it will not have any impact on the farm. But should allow people to get the right branch if they use tools like rosinstall_generator.

Note that this can only be applied to repos for which we created an ardent branch (so thid-party packages and upstream ROS 1 packages will not be able to get this change)

@dhood
Copy link
Member Author

dhood commented Aug 14, 2018

Ah cool thanks for the extra context about what this impacts. I'll update other repos where appropriate.

@dhood dhood added in progress Actively being worked on (Kanban column) and removed in review Waiting for review (Kanban column) labels Aug 14, 2018
@dhood dhood added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Aug 14, 2018
@dhood
Copy link
Member Author

dhood commented Aug 14, 2018

Other non-third-party/ROS 1 packages updated in ce0e65f

@mikaelarguedas
Copy link
Member

Can you please also update the third party packages that we forked ? (e.g. cartographer, cartographer_ros)

@dhood
Copy link
Member Author

dhood commented Aug 14, 2018

Done in da6d6e0. For future reference, urdfdom, urdfdom_headers, vision_msgs were left as ros2 since they don't have an ardent branch upstream.

@mikaelarguedas
Copy link
Member

list of repos not using the ardent branch:

console_bridge
ecl_tools
fastcdr
fastrtps
osrf_pycommon
urdfdom
urdfdom_headers
vision_msgs

All are third party or forked repos that don't have an ardent branch 👍

Copy link
Member

@mikaelarguedas mikaelarguedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dhood dhood merged commit d1f2ae3 into ros2 Aug 14, 2018
@dhood dhood deleted the ardent_fixes branch August 14, 2018 18:40
dirk-thomas pushed a commit that referenced this pull request Jan 10, 2019
* Reference ardent version for source repo

* More

* Version ros2 -> ardent

* outdated ros_workspace url
dirk-thomas pushed a commit to ros/rosdistro that referenced this pull request Jan 10, 2019
* Reference ardent version for source repo

* More

* Version ros2 -> ardent

* outdated ros_workspace url
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
in review Waiting for review (Kanban column)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants