Reference ardent version for source repo #262
Conversation
Yeah that's fine. Note that this can only be applied to repos for which we created an ardent branch (so thid-party packages and upstream ROS 1 packages will not be able to get this change) |
Ah cool thanks for the extra context about what this impacts. I'll update other repos where appropriate. |
Other non-third-party/ROS 1 packages updated in ce0e65f |
Can you please also update the third party packages that we forked ? (e.g. cartographer, cartographer_ros) |
Done in da6d6e0. For future reference, |
list of repos not using the ardent branch:
All are third party or forked repos that don't have an ardent branch 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
* Reference ardent version for source repo * More * Version ros2 -> ardent * outdated ros_workspace url
* Reference ardent version for source repo * More * Version ros2 -> ardent * outdated ros_workspace url
Looking for confirmation this is a reasonable thing to do before doing so for other repos.
Otherwise, for example, the version of
launch
on ros2index will reference the changelog off master which is incorrect.