Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add to_yaml() function for C++ messages (take 2) #527

Merged
merged 5 commits into from
Sep 11, 2020

Conversation

dirk-thomas
Copy link
Member

Redo of #523.

CI builds testing rosidl_generator_cpp but building all packages to ensure the generated code works for all messages:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@dirk-thomas dirk-thomas added the enhancement New feature or request label Sep 11, 2020
@dirk-thomas dirk-thomas self-assigned this Sep 11, 2020
This reverts commit 2330a8e.

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
Copy link
Member

@ivanpauno ivanpauno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🤞

@dirk-thomas dirk-thomas merged commit 99e05f8 into master Sep 11, 2020
@delete-merged-branch delete-merged-branch bot deleted the dirk-thomas/cpp_to_yaml2 branch September 11, 2020 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants