Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump rosidl_typesupport_introspection_tests coverage #655

Merged
merged 2 commits into from
Feb 1, 2022
Merged

Bump rosidl_typesupport_introspection_tests coverage #655

merged 2 commits into from
Feb 1, 2022

Conversation

hidmic
Copy link
Contributor

@hidmic hidmic commented Jan 31, 2022

Precisely what the title says. This patch:

  • Adds missing message introspection tests
  • Ignores redundant interface files
  • Adds missing expectations

@hidmic
Bump rosidl_typesupport_introspection_tests coverage
5c2a93f 
- Add missing message introspection tests
- Ignore redundant interface files
- Add missing expectations

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic
Copy link
Contributor Author

hidmic commented Jan 31, 2022

CI up to rosidl_typesupport_introspection_tests (w/ coverage):

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@hidmic hidmic requested a review from j-rivero January 31, 2022 18:32
@hidmic
Bump coverage
b7fa920 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic
Copy link
Contributor Author

hidmic commented Feb 1, 2022

CI up to rosidl_typesupport_introspection_tests (w/ coverage):

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@j-rivero
Copy link
Contributor

j-rivero commented Feb 1, 2022

CI up to rosidl_typesupport_introspection_tests (w/ coverage):

Wow, I see high rates for the lines coverage:

  • rosidl_typesupport_introspection_c.rosidl_typesupport_introspection_tests.msg.detail 95%
  • rosidl_typesupport_introspection_c.rosidl_typesupport_introspection_tests.srv.detail 100%
  • rosidl_typesupport_introspection_cpp.rosidl_typesupport_introspection_tests.msg.detail 98%
  • rosidl_typesupport_introspection_cpp.rosidl_typesupport_introspection_tests.srv.detail 99%

Enough to fit into the requirements of Q1. Congrats.

j-rivero
j-rivero approved these changes Feb 1, 2022
View reviewed changes
Copy link
Contributor

@j-rivero j-rivero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can not detect any problem in the code.

@hidmic hidmic merged commit 908696d into master Feb 1, 2022
@delete-merged-branch delete-merged-branch bot deleted the hidmic/rosidl_typesupport_introspection_coverage branch February 1, 2022 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-rivero j-rivero j-rivero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hidmic @j-rivero