Fix get type support handle #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Like the custom headers provided by the connext and opensplice implementations, the rosidl_typesupport_introspection_cpp package provides a generic interface for getting the type support handle. This is used by the rmw_connext_xtypes_dynamic_cpp package. This also fixes linking on Windows.
|
+1 |
1 similar comment
|
+1 |
| @@ -62,6 +62,8 @@ add_library(${rosidl_generate_interfaces_TARGET}${_target_suffix} SHARED ${_gene | |||
| if(WIN32) | |||
| target_compile_definitions(${rosidl_generate_interfaces_TARGET}${_target_suffix} | |||
| PRIVATE "ROSIDL_TSI_CPP_BUILDING_DLL") | |||
| target_compile_definitions(${rosidl_generate_interfaces_TARGET}${_target_suffix} | |||
| PRIVATE "ROSIDL_BUILDING_DLL") | |||
There was a problem hiding this comment.
According to the CMake docs it looks like that you can specify both definitions in a single invocation.
There was a problem hiding this comment.
I think I actually meant to remove the flag above, along with the whole visibility header in the rosidl_typesupport_introspection_cpp package. I'll update it one way or another.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds an implementation of the
get_type_support_handlefunctions for therosidl_typesupport_introspection_cpppackage. This used by thermw_connext_xtypes_dynamic_cpppackage to get a type support handle.Connects to ros2/ros2#26