Skip to content

Commit

Permalink
Merge pull request #175 from ros2/mergify/bp/galactic/pr-173
Browse files Browse the repository at this point in the history
Fixing generated import order (backport #173)
  • Loading branch information
quarkytale committed Jul 21, 2022
2 parents e740037 + 14104d9 commit 5a2d762
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions rosidl_generator_py/rosidl_generator_py/generate_py_impl.py
Original file line number Diff line number Diff line change
Expand Up @@ -121,9 +121,13 @@ def print_warning_if_reserved_keyword(member_name, interface_type, interface_nam

for subfolder in modules.keys():
with open(os.path.join(args['output_dir'], subfolder, '__init__.py'), 'w') as f:
for idl_stem in sorted(modules[subfolder]):
module_name = '_' + \
module_names = {}
for idl_stem in modules[subfolder]:
module_names[idl_stem] = '_' + \
convert_camel_case_to_lower_case_underscore(idl_stem)
# sorting after lower case conversion to get true order
for module_name, idl_stem in \
sorted((value, key) for (key, value) in module_names.items()):
f.write(
f'from {package_name}.{subfolder}.{module_name} import '
f'{idl_stem} # noqa: F401\n')
Expand Down

0 comments on commit 5a2d762

Please sign in to comment.