Remove dependency from rosidl_typesupport_connext_c #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clalancette
approved these changes
Mar 6, 2021
ivanpauno
approved these changes
Mar 8, 2021
Signed-off-by: Andrea Sorbini <asorbini@rti.com>
clalancette
force-pushed
the
asorbini/rmw_connextdds
branch
from
9e63746
to
fee85cc
Compare
ivanpauno
approved these changes
Mar 24, 2021
|
CI for this is at ros2/rmw_connextdds#9 (comment) (the yellow builds are because of an uncrustify failure in rclcpp that has since been fixed). So I'm going to go ahead and merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes a dependency from
rosidl_typesupport_connext_c, since it will become no longer needed oncermw_connext_cppis replaced byrmw_connextdds.See rticommunity/rmw_connextdds #9 for a list of related PRs, and an overview of all the changes required to replace ros2/rmw_connext (
rmw_connext_cpp) with rticommunity/rmw_connextdds in the ROS2 source tree.