require Python 3.6 as we use format strings in various places #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: William Woodall <william@osrfoundation.org>
sloretz
approved these changes
Jan 26, 2022
|
CI:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ran into an issue on a machine which had both Python 3.5 and Python 3.8 installed, and our software selected two different versions in various places. It seems that
PythonInterpselected the 3.5 version even though the 3.8 was also there, seeming to prefer 3.5.x "exactly" instead of just "the newest" available.Find the two versions is a different problem (two or more ways to find python in our CMake logic) that should be handled in a different set of pull requests, but the way the problem presented itself was that our Python code failed during the build of other packages due to the use of "format strings", which were introduced in Python 3.6. So this pull request (and a related one in
python_cmake_module: ros2/python_cmake_module#10) just do the bare minimum and update the required version to something we can actually use.