fix numpy usage for Windows debug builds #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirk-thomas
added
bug
dirk-thomas
force-pushed
the
numpy_windows_debug
branch
from
5f4379d
to
ea05eae
Compare
dirk-thomas
added
in progress
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
dirk-thomas
force-pushed
the
numpy_windows_debug
branch
from
ea05eae
to
88eacb2
Compare
|
Full debug build on Windows: The test failures were already present before: e.g. https://ci.ros2.org/view/nightly/job/nightly_win_deb/1202/testReport/ |
dirk-thomas
added
in review
mjcarroll
approved these changes
Apr 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #35.
Fixes ros2/build_farmer#176.
Depends on ros2/ci#272.
Before:
(failing at 
testtime)After: