fix echo of numpy.number values #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirk-thomas
added
bug
dirk-thomas
force-pushed
the
fix_echo_numpy_numbers
branch
from
f7eecff
to
333bc94
Compare
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
dirk-thomas
force-pushed
the
fix_echo_numpy_numbers
branch
from
333bc94
to
9146a91
Compare
|
Fixes the issue for me 👍 |
hidmic
approved these changes
Apr 4, 2019
jacobperron
pushed a commit
to ros2/rosidl_runtime_py
that referenced
this pull request
Sep 19, 2019
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ros2/ros2cli#213 which is a regression of #35.
Only Linux build since CI won't say much: