Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix boolean constant in Python mapping #46

Merged
merged 1 commit into from
Apr 22, 2019
Merged

fix boolean constant in Python mapping #46

merged 1 commit into from
Apr 22, 2019

Conversation

dirk-thomas
Copy link
Member

As reported in #45 (comment)

Build Status

@dirk-thomas dirk-thomas added bug Something isn't working in review Waiting for review (Kanban column) labels Apr 22, 2019
@dirk-thomas dirk-thomas self-assigned this Apr 22, 2019
@dirk-thomas dirk-thomas mentioned this pull request Apr 22, 2019
Merged
@dirk-thomas
fix boolean constant in Python mapping
7147023 
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
hidmic
hidmic approved these changes Apr 22, 2019
View reviewed changes
Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once CI is happy.

@dirk-thomas dirk-thomas merged commit 1918803 into master Apr 22, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix_boolean_constant branch April 22, 2019 19:58
@dirk-thomas dirk-thomas removed the in review Waiting for review (Kanban column) label Apr 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hidmic hidmic hidmic approved these changes

Assignees

@dirk-thomas dirk-thomas

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dirk-thomas @hidmic