fix boolean constant in Python mapping

ros2 · Apr 22, 2019 · 14566cb · 14566cb
1 parent ebad9e2
commit 14566cb
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 1 deletion.
diff --git a/rosidl_generator_py/msg/Constants.msg b/rosidl_generator_py/msg/Constants.msg
@@ -1,3 +1,5 @@
+bool FLAG_TRUE=true
+bool FLAG_FALSE=false
 int32 X=123
 int32 Y=-123
 string FOO=foo

diff --git a/rosidl_generator_py/rosidl_generator_py/generate_py_impl.py b/rosidl_generator_py/rosidl_generator_py/generate_py_impl.py
@@ -177,7 +177,7 @@ def constant_value_to_py(type_, value):
     assert value is not None
 
     if isinstance(type_, BasicType):
-        if type_.typename == 'bool':
+        if type_.typename == 'boolean':
             return 'True' if value else 'False'
 
         if type_.typename in (

diff --git a/rosidl_generator_py/test/test_interfaces.py b/rosidl_generator_py/test/test_interfaces.py
@@ -94,6 +94,8 @@ def test_constructor():
 
 
 def test_constants():
+    assert Constants.FLAG_TRUE is True
+    assert Constants.FLAG_FALSE is False
     assert 123 == Constants.X
     assert -123 == Constants.Y
     assert 'foo' == Constants.FOO