fix conversion from C to Python in case a sequence has default values #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirk-thomas
added
bug
|
Passed CI, see ros2/test_interface_files#5 (comment) |
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
dirk-thomas
force-pushed
the
dirk-thomas/sequences-with-default_values
branch
from
4af73ab
to
b8727ec
Compare
jacobperron
approved these changes
May 8, 2019
| Py_DECREF(field); | ||
| return NULL; | ||
| } | ||
| // clear the array, poor approach to remove potential default values |
There was a problem hiding this comment.
We could also create a new array object with the same typecode. But I'm not sure if this would be any prettier, or if we still need to worry about decref'ing the individual elements.
In any case, this looks okay to me with green CI.
There was a problem hiding this comment.
I would be happy to do so but couldn't figure out how to instantiate an array.array from the C code when I wrote this originally 😞
delete-merged-branch
bot
deleted the
dirk-thomas/sequences-with-default_values
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we currently don't have a way to construct a Python message class without its default values we have to remove them before populating the
array.arrayfields usingfrombytes.Related to ros2/test_interface_files#5.